[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

2020-01-29 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. This looks fine but could you also change the title of the patch please? This patch doesn't really have anything to do with remote debugging (though it's fine to mention that this is e

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

2020-01-28 Thread Ayke via Phabricator via lldb-commits
aykevl added a comment. It's worth noting that I haven't managed to get a line table from a binary produced by LLVM (with my own compiler frontend) and linked by avr-gcc. But I believe that is a bug in the AVR backend of LLVM as a binary built entirely by `avr-gcc` works just fine. CHANGES SI

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

2020-01-28 Thread Ayke via Phabricator via lldb-commits
aykevl updated this revision to Diff 240857. aykevl added a comment. Herald added subscribers: MaskRay, emaste. Herald added a reviewer: espindola. @labath Thank you for the quick review! I have added a test per your suggestions. I'm not very familiar with lldb but this passes the tests. CHANG

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

2020-01-28 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thanks for the patch, and in particular for starting with a small increment instead of a giant implement-all patch. Could you please add a simple test case that runs `yaml2obj | lldb-test object-file` and verifies that the avr object file is parsed properly. (The archit

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

2020-01-28 Thread Ayke via Phabricator via lldb-commits
aykevl created this revision. aykevl added reviewers: dylanmckay, deepak2427, Andrzej, clayborg, labath. Herald added subscribers: lldb-commits, Jim, aprantl. Herald added a project: LLDB. Add bare-metal AVR support to lldb. Loading a binary works, but little else. Things that work: $ ./llvm-b