[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

labath added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2041 void ValueObject::GetExpressionPath(Stream &s, bool qualify_cxx_base_classes, GetExpressionPathFormat epformat) { xiaobai wrote: > labath wrote

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

xiaobai added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2041 void ValueObject::GetExpressionPath(Stream &s, bool qualify_cxx_base_classes, GetExpressionPathFormat epformat) { labath wrote: > Should we re

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

labath added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2041 void ValueObject::GetExpressionPath(Stream &s, bool qualify_cxx_base_classes, GetExpressionPathFormat epformat) { Should we remove the `qualify

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG5eaf44f99f0a: [lldb] Delete ValueObject::GetBaseClassPath (authored by xiaobai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73517/new/ https://reviews.ll

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Doesn't look like it's used in the swift fork downstream either. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73517/new/ https

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

xiaobai added a comment. Note: This makes D69820 unnecessary so I will close that if this goes through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73517/new/ https://reviews.llvm.org/D73517 _

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

xiaobai created this revision. xiaobai added reviewers: teemperor, labath, clayborg, JDevlieghere. Herald added a project: LLDB. This method has exactly one call site, which is only actually executed if `ValueObject::IsBaseClass` returns false. However, the first thing that `ValueObject::GetBaseCl