[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread walter erquinigo via Phabricator via lldb-commits
wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:960 +int commit_points_index = -1; +for (uint32_t breakpoint_index = 0; breakpoint_index < commit_points.size(); breakpoint_index++) { + int breakpoint_position = match.rfind(commit_po

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240701. diazhector98 added a comment. Uncomment @skipIfDarwin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org/D73506 Files: lldb/packages/Python/lldbsuite/test/tools/l

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240700. diazhector98 added a comment. Added more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org/D73506 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vsc

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240694. diazhector98 added a comment. 1. Updating D73506 : Bug fix # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240693. diazhector98 added a comment. 1. Updating D73506 : Bug fix # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240687. diazhector98 added a comment. 1. Updating D73506 : Bug fix # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240683. diazhector98 added a comment. 1. Updating D73506 : Bug fix # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 planned changes to this revision. diazhector98 marked 5 inline comments as done. diazhector98 added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py:122 +self.verify_completions( +

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 created this revision. diazhector98 added a reviewer: wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. diazhector98 planned changes to this revision. diazhector98 marked 5 inline comments as done. diazhector98 added inline comments. Com