[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib marked 9 inline comments as done. mib added inline comments. Comment at: lldb/docs/use/formatting.rst:137 +---+---

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

JDevlieghere added inline comments. Comment at: lldb/docs/use/formatting.rst:137 +---+

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib updated this revision to Diff 240543. mib marked 12 inline comments as done. mib added a comment. Changed the RecognizedStackFrame and AbortRecognizedStackFrame to add a StopReasonDescription method instead of a StopInfo instance. This way, lldb can show a special stop reason description, fo

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

jingham added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:81 +ThreadSP thread_sp, FileSpec module_spec, ConstString function_name) { + const uint32_t frames_to_fetch = 10; + StackFrameSP prev_frame_sp = nullptr; jingham wrote: > mib

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

friss added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:81 +ThreadSP thread_sp, FileSpec module_spec, ConstString function_name) { + const uint32_t frames_to_fetch = 10; + StackFrameSP prev_frame_sp = nullptr; jingham wrote: > mib wr

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib updated this revision to Diff 240238. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73303/new/ https://reviews.llvm.org/D73303 Files: lldb/include/lldb/Target/AbortRecognizer.h lldb/include/lldb/Target/StackFrameRecognizer.h lldb/include/l

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

jingham added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:81 +ThreadSP thread_sp, FileSpec module_spec, ConstString function_name) { + const uint32_t frames_to_fetch = 10; + StackFrameSP prev_frame_sp = nullptr; mib wrote: > friss wr

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:81 +ThreadSP thread_sp, FileSpec module_spec, ConstString function_name) { + const uint32_t frames_to_fetch = 10; + StackFrameSP prev_frame_sp = nullptr;

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

friss added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:81 +ThreadSP thread_sp, FileSpec module_spec, ConstString function_name) { + const uint32_t frames_to_fetch = 10; + StackFrameSP prev_frame_sp = nullptr; mib wrote: > JDevlieghe

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib updated this revision to Diff 240213. mib marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73303/new/ https://reviews.llvm.org/D73303 Files: lldb/include/lldb/Target/AbortRecognizer.h lldb/include/lldb/Target/S

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib marked 14 inline comments as done. mib added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:1 +//===-- AbortRecognizer.cpp -*- C++ -*-===// +// teemperor wrote: > Please remove the `-*- C++ -*-` as tha

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

teemperor added inline comments. Comment at: lldb/include/lldb/Target/AbortRecognizer.h:29 + GetAbortLocation(Process *process_sp); + static llvm::Optional> + GetAssertLocation(Process *process_sp); This function (especially the return types) deserve some docu

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

friss added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:126-127 + // Fetch abort location + auto abort_location = + AbortRecognizerHandler::GetAbortLocation(process_sp.get()); + Why do you even check the abort location? The recogniz

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/AbortRecognizer.h:27 + + static llvm::Optional> + GetAbortLocation(Process *process_sp); This doesn't really look much like a class with just two static member functions. Assuming that th

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:109 + + // FIXME: This breaks several tests. + // m_stop_info_sp = StopInfo::CreateStopReasonForRecognizedFrame( The tests failures happen becau

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib added a comment. I'm sending this first implementation looking for feedbacks, it is not passing all the tests and will probably change in the near future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73303/new/ https://reviews.llvm.org/D73303

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib created this revision. mib added reviewers: jingham, friss, LLDB. mib added a project: LLDB. Herald added subscribers: lldb-commits, jfb, mgorny. When a thread stops on an abort frame, the recognizer will unwind the stack to look for the frame from which the assert was triggered. Once located,