[Lldb-commits] [PATCH] D73112: [lldb/DWARF] Remove one more auto-dwo method

2020-01-22 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3d7177acd751: [lldb/DWARF] Remove one more auto-dwo method (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73112/new/ https://reviews.ll

[Lldb-commits] [PATCH] D73112: [lldb/DWARF] Remove one more auto-dwo method

2020-01-21 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Thanks for doing the cleanup. After we switched over to using the DWARFDie more, there are probably many more cleanups like this where the code didn't get converted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73112/new

[Lldb-commits] [PATCH] D73112: [lldb/DWARF] Remove one more auto-dwo method

2020-01-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73112/new/ https://reviews.llvm.org/D73112 ___

[Lldb-commits] [PATCH] D73112: [lldb/DWARF] Remove one more auto-dwo method

2020-01-21 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. Our DWARFUnit was automatically forwarding the requests to the split unit when looking for a DIE by offset. llvm::DWARFUnit does not do that, and