[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

davide added a comment. In D72413#1813630 , @teemperor wrote: > The C++ expression parser will probably behave incredibly incorrectly without > a persistent state but before this patch it just crashed, so I think this is > good to go. Should we conside

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9331a56fead: Add missing nullptr checks. (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ http

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D72413#1811038 , @aprantl wrote: > In D72413#1810969 , @jingham wrote: > > > If we can't make a persis

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

teemperor added a comment. The C++ expression parser will probably behave incredibly incorrectly without a persistent state but before this patch it just crashed, so I think this is good to go. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ https://reviews.llvm.org/D72413

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

davide added a comment. @teemperor what do you think? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ https://reviews.llvm.org/D72413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

davide added a comment. In D72413#1812464 , @aprantl wrote: > Should we merge this like that, or is there a better way of doing this? We should merge it like this, IMHO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ https://reviews.

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

aprantl added a comment. Should we merge this like that, or is there a better way of doing this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ https://reviews.llvm.org/D72413 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

aprantl added a comment. > Do we currently have a way to end up in this state? Not in llvm.org. This was prompted by a swift-lldb-crash where we can end up with no Swift context after a catastrophic error. I believe that in practice the clang runtimes are always available, but the API returns a

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

shafik added a reviewer: shafik. shafik added a comment. I am curious what prompted this set of changes, they look sensible but I don't see how we can do anything useful if we end up in this state. Do we currently have a way to end up in this state? CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

aprantl added a comment. In D72413#1810969 , @jingham wrote: > If we can't make a persistent expression state, are we going to be able to do > anything useful with expressions? I don't see anything wrong here, but it > seems like we should really be put

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

jingham added a comment. If we can't make a persistent expression state, are we going to be able to do anything useful with expressions? I don't see anything wrong here, but it seems like we should really be putting up a crunchy frog warning and erroring out of "expr"directly if we really can'

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

davide added a comment. Raphael and Jim should look at the expression evaluator bits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ https://reviews.llvm.org/D72413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

aprantl created this revision. aprantl added reviewers: JDevlieghere, jingham. GetPersistentExpressionStateForLanguage() can return a nullptr if it cannot construct a typesystem. This patch adds missing nullptr checks at all uses. Inspired by rdar://problem/58317195 https://reviews.llvm.org/D7