[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3757f3091d1: [lldb/CMake] Autodetect Python dependency (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D72107?vs=235942&id=236393#toc Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks fine to me. Thanks for tackling this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72107/new/ https://reviews.llvm.org/D72107 _

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

mgorny added inline comments. Comment at: lldb/cmake/modules/FindPythonInterpAndLibs.cmake:2 +#.rst: +# FindPythonInterpndLibs +# --- Typo. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72107/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

JDevlieghere added a comment. In D72107#1802048 , @xiaobai wrote: > In D72107#1802029 , @JDevlieghere > wrote: > > > Do you mean forcing `LLDB_ENABLE_PYTHON` to on so that it fails in case the > > logic changes an

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

xiaobai added a comment. In D72107#1802029 , @JDevlieghere wrote: > Do you mean forcing `LLDB_ENABLE_PYTHON` to on so that it fails in case the > logic changes and Python isn't found? Yes, something like that. It looks like the previous expected behavi

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

JDevlieghere added a comment. In D72107#1802001 , @xiaobai wrote: > It's nice to consolidate the logic into one place. I think you will probably > need to make an appropriate change on the buildbot side as well (if you > haven't done that already). Do

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

xiaobai added a comment. It's nice to consolidate the logic into one place. I think you will probably need to make an appropriate change on the buildbot side as well (if you haven't done that already). Where is `FindPythonInterpAndLibs` being included? Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

JDevlieghere created this revision. JDevlieghere added reviewers: labath, compnerd, xiaobai. Herald added a subscriber: mgorny. Herald added a project: LLDB. Python was the last remaining "optional" dependency for LLDB. This moves the code to find Python into `FindPythonInterpAndLibs` using the s