This revision was automatically updated to reflect the committed changes.
Closed by commit rG7eaae939b9bb: [FormatEntity] Add mangled function name
support (authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71237/new/
https://reviews.l
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71237/new/
https://reviews.llvm.org/D71237
___
lldb-commits mailing list
mib updated this revision to Diff 233473.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71237/new/
https://reviews.llvm.org/D71237
Files:
lldb/docs/use/formatting.rst
lldb/include/lldb/Core/FormatEntity.h
lldb/source/Core/FormatEntity.cpp
lldb/test/Shell/Settings/Inputs/main.cpp
mib updated this revision to Diff 233465.
mib added a comment.
Run clang-format.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71237/new/
https://reviews.llvm.org/D71237
Files:
lldb/docs/use/formatting.rst
lldb/include/lldb/Core/FormatEntity.h
lldb/source/Core/FormatEntity.cpp
mib updated this revision to Diff 233464.
mib added a comment.
Simplifying the test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71237/new/
https://reviews.llvm.org/D71237
Files:
lldb/docs/use/formatting.rst
lldb/include/lldb/Core/FormatEnti
mib updated this revision to Diff 233463.
mib marked 5 inline comments as done.
mib added a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71237/new/
https://reviews.llvm.org/D71237
Files:
lldb/docs/use/formatting.rst
lldb/include/lldb/C
JDevlieghere added inline comments.
Comment at: lldb/source/Core/FormatEntity.cpp:1763
+ return false;
+else {
+ s.PutCString(name);
No else after return
Comment at: lldb/source/Core/FormatEntity.cpp:1768
+Block *inline_bl
mib updated this revision to Diff 233189.
mib marked 4 inline comments as done.
mib added a comment.
Remove unnecessary Language FunctionNameRepresention changes.
Rewrote test file. Refactored frame-format FormatEntity.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://r
labath added a comment.
No opinion on the code, but I think the test needs to be cleaned up _a lot_.
Comment at: lldb/test/Shell/Settings/Inputs/main.cpp:1
+//===-- main.cpp *- C++
-*-===//
+//
This file is about
jingham added a comment.
If you make the frame format such that it is easy to pull the mangled &
demangled names out of the format output (e.g. ###${function.mangled-name}###
???${function.name}) then you could check that the two names are different, and
for extra credit you could use "lang c++
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Target/Language.h:146
+eNameWithNoArgs,
+eMangledName
};
`eNameMangled`?
Comment at: lldb/source/Core/FormatEntity.cpp:1754
+StreamString ss;
+if (sc->functio
mib updated this revision to Diff 232976.
mib added a comment.
Mark test as unsupported for windows.
Run clang-format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71237/new/
https://reviews.llvm.org/D71237
Files:
lldb/docs/use/formatting.rst
xiaobai added inline comments.
Comment at: lldb/test/Shell/Settings/Inputs/main.cpp:95
+
+//virtual
+~C()
nit: comment unneeded.
Comment at: lldb/test/Shell/Settings/TestFrameFormatMangling.test:9
+frame info
+# CHECK: frame #0: {{.*}}_
jasonmolenda marked an inline comment as done.
jasonmolenda added inline comments.
Comment at: lldb/test/Shell/Settings/TestFrameFormatMangling.test:9
+frame info
+# CHECK: frame #0: {{.*}}_ZN1CC2Eiii
+c
Is this mangled name going to be the same on windows?
Rep
mib created this revision.
Herald added a project: LLDB.
mib added a reviewer: LLDB.
Add `function.mangled-name` key for FormatEntity to show the mangled
function names in backtraces.
rdar://54088244
Signed-off-by: Med Ismail Bennani
Repository:
rG LLVM Github Monorepo
https://reviews.llvm
15 matches
Mail list logo
