This revision was automatically updated to reflect the committed changes.
Closed by commit rG62a6d9770450: Do not cache hardcoded formats in
FormatManager (authored by aprantl).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
And check the Accept checkbox...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71233/new/
https://reviews.llvm.org/D71233
___
lldb-com
jingham added a comment.
This looks fine to me. So long as there wasn't much strict type-based matching
done in the Hardcoded Summary providers, then this shouldn't cause the format
matching to get slower.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71233/new/
https://reviews.llvm.
aprantl updated this revision to Diff 233145.
aprantl added a comment.
Rebase.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71233/new/
https://reviews.llvm.org/D71233
Files:
lldb/include/lldb/DataFormatters/FormatManager.h
lldb/packages/Python/lldbsuite/test/functionalities/data-
aprantl created this revision.
aprantl added reviewers: jingham, davide.
aprantl added a parent revision: D71231: Replace redundant code in
FormatManager and FormatCache with templates (NFC).
The cache in FormatCache uses only a type name as key. The hardcoded formats,
synthetic children, etc in
