[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70885/new/ https://reviews.llvm.org/D70885 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

aadsm updated this revision to Diff 302180. aadsm added a comment. Herald added a subscriber: JDevlieghere. Herald added a reviewer: JDevlieghere. Use set and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70885/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

clayborg added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py:353-354 'target create "%s"' % (program), -'br s -f main.c -l %d' % first_line, -'br s -f main.c -l %d' % second_lin

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

lanza added a comment. Sorry for bump to this old diff, but I agree with both Jim and Greg -- we shouldn't be importing your `~/.lldbinit`, but tests shouldn't depend on there never being another `br s`. This change should land as `breakpoint set`. Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

jingham added a comment. I don't think it is wise to use shortened command names like "br" in a test if you aren't testing shortest command string. We don't guarantee that we will keep all currently unique shortened command names unique in perpetuity... Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

aadsm added a comment. Yeah, that's what I do in D70882 . I still think tests can be more robust by using explicit lldb command names but don't really care much :). I'm happy to abandon it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We shouldn't be running the test suite that allows your ~/.lldbinit file to be run. This can really hose up many things, so we should change the lldb-vscode test suite to not all

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

aadsm created this revision. aadsm added reviewers: clayborg, lanza, wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Not a big deal but might be if in the future we had another command starting with br. I found this because I had an lldbinit that added a breakpad c