[Lldb-commits] [PATCH] D70884: [lldb] Fix TestFormattersSBAPI test

2019-12-02 Thread António Afonso via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGafd5d912812e: [lldb] Fix TestFormattersSBAPI test (authored by aadsm, committed by António Afonso ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D70884: [lldb] Fix TestFormattersSBAPI test

2019-12-02 Thread António Afonso via Phabricator via lldb-commits
aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/python_api/formatters/TestFormattersSBAPI.py:71 -format.format = lldb.eFormatOctal +format.SetFormat(lldb.eFormatOctal) category.AddTyp

[Lldb-commits] [PATCH] D70884: [lldb] Fix TestFormattersSBAPI test

2019-12-02 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/python_api/formatters/TestFormattersSBAPI.py:71 -format.format = lldb.eFormatOctal +format.SetForma

[Lldb-commits] [PATCH] D70884: [lldb] Fix TestFormattersSBAPI test

2019-12-01 Thread António Afonso via Phabricator via lldb-commits
aadsm created this revision. aadsm added reviewers: clayborg, lanza, wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test was broken in two ways: - Using the wrong API (e.g.: format = instead of SetFormat) - The hex checker was only checking "01" which will pa