This revision was automatically updated to reflect the committed changes.
Closed by commit rGafd5d912812e: [lldb] Fix TestFormattersSBAPI test (authored
by aadsm, committed by António Afonso ).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.
aadsm marked an inline comment as done.
aadsm added inline comments.
Comment at:
lldb/packages/Python/lldbsuite/test/python_api/formatters/TestFormattersSBAPI.py:71
-format.format = lldb.eFormatOctal
+format.SetFormat(lldb.eFormatOctal)
category.AddTyp
clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.
Comment at:
lldb/packages/Python/lldbsuite/test/python_api/formatters/TestFormattersSBAPI.py:71
-format.format = lldb.eFormatOctal
+format.SetForma
aadsm created this revision.
aadsm added reviewers: clayborg, lanza, wallace.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This test was broken in two ways:
- Using the wrong API (e.g.: format = instead of SetFormat)
- The hex checker was only checking "01" which will pa