shafik added a comment.
Yeah, there was indeed some ugly code there, nice work!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70663/new/
https://reviews.llvm.org/D70663
___
lldb-commits mailing list
ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7a6588abf8ba: [lldb] Remove lldb's own ASTDumper
(authored by teemperor).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70663/new/
https://reviews.llvm.org/
teemperor updated this revision to Diff 230875.
teemperor added a comment.
- Address feedback (Thanks Pavel)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70663/new/
https://reviews.llvm.org/D70663
Files:
lldb/include/lldb/Symbol/ClangUtil.h
lldb/source/Plugins/ExpressionParser/Cla
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Yay
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:1675
+ " CEDM::FEVD[{0}] Found variable {1}, returned\n{2} (original
{3})",
teemperor created this revision.
teemperor added a reviewer: labath.
Herald added subscribers: lldb-commits, JDevlieghere, mgorny.
Herald added a project: LLDB.
LLDB's ASTDumper is just a clone of Clang's ASTDumper but with some scary code
and
some unrelated functionality (like dumping name/attri