[Lldb-commits] [PATCH] D70663: [lldb] Remove lldb's own ASTDumper

2019-12-03 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. Yeah, there was indeed some ugly code there, nice work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70663/new/ https://reviews.llvm.org/D70663 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D70663: [lldb] Remove lldb's own ASTDumper

2019-11-25 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7a6588abf8ba: [lldb] Remove lldb's own ASTDumper (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70663/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D70663: [lldb] Remove lldb's own ASTDumper

2019-11-25 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor updated this revision to Diff 230875. teemperor added a comment. - Address feedback (Thanks Pavel) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70663/new/ https://reviews.llvm.org/D70663 Files: lldb/include/lldb/Symbol/ClangUtil.h lldb/source/Plugins/ExpressionParser/Cla

[Lldb-commits] [PATCH] D70663: [lldb] Remove lldb's own ASTDumper

2019-11-25 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yay Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:1675 + " CEDM::FEVD[{0}] Found variable {1}, returned\n{2} (original {3})",

[Lldb-commits] [PATCH] D70663: [lldb] Remove lldb's own ASTDumper

2019-11-25 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere, mgorny. Herald added a project: LLDB. LLDB's ASTDumper is just a clone of Clang's ASTDumper but with some scary code and some unrelated functionality (like dumping name/attri