This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc8dfe907299e: [Reproducer] Generate LLDB reproducer on crash
(authored by JDevlieghere).
Repository:
rG LLVM Github Mon
vsk added a comment.
This looks good to me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70474/new/
https://reviews.llvm.org/D70474
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
JDevlieghere updated this revision to Diff 230288.
JDevlieghere added a comment.
Update the tests with uppercase signal names
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70474/new/
https://reviews.llvm.org/D70474
Files:
lldb/include/lldb/API/SBReproducer.h
lldb/source/API/SBRepro
JDevlieghere updated this revision to Diff 230286.
JDevlieghere marked 4 inline comments as done.
JDevlieghere added a comment.
Address review feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70474/new/
https://reviews.llvm.org/D70474
Files:
lldb/include/lldb/API/SBReproducer.
labath added a comment.
I think this looks pretty good. This is going to do a _lot_ of work in the
signal handler, which may or may not work. However, at the point when this code
gets invoked, we're already in undefined behavior territory anyway, so we might
as well give it a shot. The dumping
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, vsk, jingham, friss.
Herald added a reviewer: jfb.
Herald added a project: LLDB.
JDevlieghere edited the summary of this revision.
Herald added a subscriber: dexonsmith.
This patch hooks the reproducer infrastructure with th
