rovka updated this revision to Diff 229505.
rovka added a comment.
Addressed @labath's comment (test run in progress). Thanks for having a look!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70303/new/
https://reviews.llvm.org/D70303
Files:
lldb/packages/Python/lldbsuite/test/comman
labath added a comment.
Looks reasonable, but I'd suggest using something more unique for the
breakpoint placement. Feel free to add some comment to the .cpp file and then
search for that in python (that's what most of our other tests tend to do).
CHANGES SINCE LAST ACTION
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5f0c3bad2f03: Fix TestFormatters.py stepping too far
(authored by rovka).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70303/n
rovka created this revision.
rovka added reviewers: omjavaid, lawrence_danna.
Herald added a subscriber: kristof.beyls.
TestFormatters.py has a sequence of three 'next' commands to get past
all the initializations in the test function. On AArch64 (and
potentially other platforms), this was one 'ne
