This revision was automatically updated to reflect the committed changes.
Closed by commit rG4d23764dddc2: Fix -Wunused-result warnings in LLDB (authored
by rnk).
Changed prior to commit:
https://reviews.llvm.org/D70281?vs=229421&id=229667#toc
Repository:
rG LLVM Github Monorepo
CHANGES SIN
jingham added a comment.
There's a PP above each instance of this code explaining why it's okay if we
don't get the API lock, since that's a bit of a tricky point. So if you want
to add a comment, it would be better to say "see explanation above".
Repository:
rG LLVM Github Monorepo
CHANGE
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
LGTM.
It's too bad that pattern is repeated three times, including the explanatory
comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D7
rnk created this revision.
rnk added a reviewer: amccarth.
Herald added a project: LLDB.
Three uses of try_lock intentionally ignore the result. Make that
explicit with a void cast.
Add what appears to be a missing return in the clang expression parser
code. It's a functional change, but presumab
