[Lldb-commits] [PATCH] D69933: [ASTImporter] Limit imports of structs

2020-01-21 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Clang AST contexts know how to complete types and is done via the external AST source code that will ask a type to complete itself. Each object file has an AST that knows how to lazily complete a type when and only when it is needed. Each object file also only knows ab

[Lldb-commits] [PATCH] D69933: [ASTImporter] Limit imports of structs

2020-01-21 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. I really don't think the ASTImporter should ever manipulate records in the source context (effectively the source context should be considered immutable). It also seems *very* wrong that what we import depends in any way on a previous expression so I agree we should f

[Lldb-commits] [PATCH] D69933: [ASTImporter] Limit imports of structs

2020-01-21 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 239235. jarin added a comment. Herald added a subscriber: lldb-commits. I changed the diff so that it does not touch Clang's AST importer, instead it patches LLDB's wrapper of the AST importer. The idea is to only import complete a record if the current evalua