This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGff9d73288738: crashlog.py: Improve regular expressions
(authored by aprantl).
Herald added a project: LLDB.
Changed prior
aprantl updated this revision to Diff 228139.
aprantl added a comment.
Added some more tests as suggested by Jason and made the regex slightly more
robust by requiring a `/` at the beginning of `img_path`. All crashlogs I found
were meeting this requirement.
CHANGES SINCE LAST ACTION
https:/
aprantl updated this revision to Diff 228141.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69871/new/
https://reviews.llvm.org/D69871
Files:
lldb/examples/python/crashlog.py
lldb/test/Shell/Python/crashlog.test
Index: lldb/test/Shell/Python/crashlog.test
===
jasonmolenda added a comment.
I'll be honest I'm having trouble thinking of all the possible problems these
regexes might have just by looking at them, but overall this looks good to me.
Should we add a couple of extra file-check tests for variations in the version
number part of the binary lis
aprantl created this revision.
aprantl added reviewers: jingham, jasonmolenda.
Herald added a subscriber: kristof.beyls.
aprantl edited the summary of this revision.
This is yet another change to the regular expressions in crashlog.py that fix a
few edge cases, and attempt to improve the readabil
