This revision was automatically updated to reflect the committed changes.
Closed by commit rG9c739252261e: [lldb/lit] Introduce %clang_host substitutions
(authored by labath).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69619/new/
https://reviews.
labath added a comment.
Thanks guys.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69619/new/
https://reviews.llvm.org/D69619
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
JDevlieghere accepted this revision.
JDevlieghere added a comment.
All my thoughts have already been brought up and discussed. :-)
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69619/new/
https://reviews.llvm.org/D69619
__
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
> The one barrier we have right now is that it is not possible to run the "lit"
> suite with a different compiler, and that's something I think we should keep.
Very much agreed.
> For the t
labath added a comment.
Yes, I understand what you're saying, but I am afraid the situation is not as
clear-cut as that. I would be very happy if it was, but it's definitely not the
current situation, and given the complexities involved, I'm not sure if we
should even aim for that goal. I mean,
aprantl added a comment.
this looks like a reasonable incremental improvement. That said, I'm wondering
how useful `clang_host` is as a concept in the LIT tests. In my own mental
model the tests are grouped into
1. end-to-end tests that test lldb against a variety of user-configurable
compiler
labath created this revision.
labath added reviewers: JDevlieghere, aprantl, mstorsjo.
Herald added subscribers: jfb, MaskRay, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLDB.
This patch addresses an ambiguity in how our existing tests invoke the
compiler. Rou
