Re: [Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

I have removed the extra quotation marks in https://reviews.llvm.org/rZORGe249863ac732. The change applied to staging and will wait the next master restart tonight. Thanks Galina On Thu, Oct 31, 2019 at 3:35 AM Pavel Labath via Phabricator wrote: > > labath added a comment. > > In D69555#17282

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

labath added a comment. In D69555#1728291 , @labath wrote: > (which actually surprises me a lot) Actually, nevermind. The linux bot fails now in the same way as the windows one (http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/6262). Galina,

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

labath marked an inline comment as done. labath added a comment. In D69555#1727882 , @stella.stamenova wrote: > Sadly, I think this broke the windows bot now (assuming it got applied to > staging, otherwise I have to figure out what did): > > http://lab.

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

gkistanova added a comment. The cmake command redefinition effectively is not supported any more, but the 'cmake' arg is left behind. + inline comments. These have been addressed by https://reviews.llvm.org/rZORG425eeb1bf21b. Comment at: zorg/buildbot/builders/LLDBBuilder.py:

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

stella.stamenova added a comment. Sadly, I think this broke the windows bot now (assuming it got applied to staging, otherwise I have to figure out what did): http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/46/steps/cmake-configure/logs/stdio Repository: rZORG LLVM Github Zor

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

This revision was automatically updated to reflect the committed changes. Closed by commit rZORGa342b84f8576: [zorg] Fix LLDBCmakeBuildFactory (authored by labath). Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69555/new/ https://reviews.llvm.org/D69

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

stella.stamenova accepted this revision. stella.stamenova added a comment. Thanks @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69555/new/ https://reviews.llvm.org/D69555 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. It does run now, I did not test it with a slave. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69555/new/ https://reviews.llvm.org/D69555

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

labath updated this revision to Diff 226872. labath added a comment. import FileDoesNotExist CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69555/new/ https://reviews.llvm.org/D69555 Files: zorg/buildbot/builders/LLDBBuilder.py Index: zorg/buildbot/builders/LLDBBuilder.py ==

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

jankratochvil requested changes to this revision. jankratochvil added a comment. This revision now requires changes to proceed. 2019-10-29 11:38:04+0100 [-] error while parsing config file 2019-10-29 11:38:04+0100 [-] Unhandled Error Traceback (most recent call last): File "

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

labath created this revision. labath added reviewers: jankratochvil, stella.stamenova, gkistanova. The attempt in D69341 was not complete, as in the monorepo world, we also need to pass LLVM_ENABLE_PROJECTS in order to build lldb (and clang and lld). This also u