[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

compnerd closed this revision. compnerd added a comment. GIT 2046d72e916 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69535/new/ https://reviews.llvm.org/D69535

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Sorry, I was out on vacation until today :). The bot is actually running 3.14 already, I updated the host file to reflect that. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

compnerd added a comment. @stella.stamenova ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69535/new/ https://reviews.llvm.org/D69535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

labath added a comment. This looks fine to me, and it's really great to get rid of the that code, but it would be good for some some "windows person" to ack this too. I'm particularly interested in Stella's opinion, as according to http://lab.llvm.org:8011/buildslaves/win-py3-buildbot, her bot

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

compnerd updated this revision to Diff 230658. compnerd added a comment. Use @labath's suggestion of bumping minimum required version for Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69535/new/ https://reviews.llvm.org/D69535 Files: lld

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

amccarth added a comment. In D69535#1724797 , @labath wrote: > .. Given that this code is python3 specific and other platforms still support > python2, maybe we can make this bump windows-specific at first, and then > extend it to other platforms once we

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

compnerd marked an inline comment as done. compnerd added a comment. Yeah, doing an incremental rollout makes sense. Comment at: lldb/cmake/modules/LLDBConfig.cmake:225 + if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.13 AND CMAKE_SYSTEM_NAME STREQUAL Windows) +find_package(Pyt

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

labath added subscribers: aleksandr.urakov, amccarth, ted, labath. labath added a comment. Yeah, I'd still like to avoid having multiple paths for configuring python, as one of them is bound to end up broken sooner or later. However, given that there's already talk about bumping the minimum cmak

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

compnerd added a comment. The reason for bringing this back up as a Windows specific thing is that currently, there is no good way to build LLDB with python support without having to specify additional details on *just* windows because the windows path is doing something special. This is tryin

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

JDevlieghere added a comment. I proposed this in https://reviews.llvm.org/D64881 and the consensus was that we didn't want to do this. Also I don't think this should be a Windows-only thing. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69535/new/ https://rev

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

compnerd created this revision. compnerd added reviewers: xiaobai, stella.stamenova. Herald added subscribers: JDevlieghere, mgorny. Herald added a project: LLDB. If we have a new enough CMake, use `find_package(Python3)`. This version is able to check both 32-bit and 64-bit versions and will se