[Lldb-commits] [PATCH] D69451: Inline variable only used in assertion

2019-10-25 Thread Shu-Chun Weng via Phabricator via lldb-commits
scw added a comment. Missed my alias and used the command line for other projects instead :/ Yes, please commit it for me as I don't have the permission. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69451/new/ https://reviews.llvm.org/D69451 _

[Lldb-commits] [PATCH] D69451: Inline variable only used in assertion

2019-10-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG10b5cd8ed527: [LLDB] Fix inline variable only used in assertion. (NFC) (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69451/new/

[Lldb-commits] [PATCH] D69451: Inline variable only used in assertion

2019-10-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Thanks! Please let me know if you need me to commit this for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69451/new/ https://reviews.llvm.org/D69451 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D69451: Inline variable only used in assertion

2019-10-25 Thread Shu-Chun Weng via Phabricator via lldb-commits
scw updated this revision to Diff 226512. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69451/new/ https://reviews.llvm.org/D69451 Files: lldb/utils/TableGen/LLDBPropertyDefEmitter.cpp Index: lldb/utils/TableGen/LLDBPropertyDefEmitter.cpp =

[Lldb-commits] [PATCH] D69451: Inline variable only used in assertion

2019-10-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. PS: In the future please uploaded full-context diffs . Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D69451: Inline variable only used in assertion

2019-10-25 Thread Shu-Chun Weng via Phabricator via lldb-commits
scw created this revision. scw added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This prevents unused variable warning/error in -DNDEBUG builds. The variable was introduced in rG5934cd11ea3e