[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1e0ae3420b6: COFF: Set section permissions (authored by labath). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D69102?vs=225403&id=227077#toc Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

mstorsjo added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:800 /*flags*/ 0); +header_sp->SetPermissions(ePermissionsReadable); m_sections_up->AddSection(header_sp); mstorsjo wrote: > labath wrote: > > labat

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

mstorsjo accepted this revision. mstorsjo added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:800 /*flags*/ 0); +header_sp->SetPermissions(ePermissionsReadable); m_sections_up-

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:800 /*flags*/ 0); +header_sp->SetPermissions(ePermissionsReadable); m_sections_up->AddSection(header_sp); la

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

labath created this revision. labath added reviewers: amccarth, mstorsjo. labath added a parent revision: D69100: COFF: Create a separate "section" for the file header. labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/P

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:800 /*flags*/ 0); +header_sp->SetPermissions(ePermissionsReadable); m_sections_up->AddSection(header_sp); Ar