[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get()); return *this; } - void Reset(PythonObject &&other)

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

This revision was automatically updated to reflect the committed changes. Closed by commit rG03819d1c80ad: eliminate one form of PythonObject::Reset() (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69080/new/ https://rev

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna updated this revision to Diff 225492. lawrence_danna added a comment. universal assignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69080/new/ https://reviews.llvm.org/D69080 Files: lldb/source/Plugins/ScriptInterpreter/Pytho

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get());

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get()); return *this; } - void Reset(PythonObject &&other)

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get());

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get()); return *this; } - void Reset(PythonObject &&other)

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna marked 3 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get());

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get()); return *this; } - void Reset(PythonObject &&other)

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get());

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I like where this is going. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) {

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna updated this revision to Diff 225350. lawrence_danna added a comment. include move version too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69080/new/ https://reviews.llvm.org/D69080 Files: lldb/source/Plugins/ScriptInterpreter/P

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, clayborg, labath, jingham. Herald added a project: LLDB. I'd like to eliminate all forms of Reset() and all public constructors on these objects, so the only way to make them is with Take<> and Retain<> and the on