[Lldb-commits] [PATCH] D69035: minidump: Refactor memory region computation code

2019-10-25 Thread Pavel Labath via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7c603a41e20f: lldb/minidump: Refactor memory region computation code (authored by labath). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D69035: minidump: Refactor memory region computation code

2019-10-17 Thread Pavel Labath via Phabricator via lldb-commits
labath requested review of this revision. labath added a comment. With some additional COFF tweaks (D69100 , D69102 ), the next patch doesn't turn out that bad (though I'm still happy to accept "unwinder should just check section

[Lldb-commits] [PATCH] D69035: minidump: Refactor memory region computation code

2019-10-16 Thread Pavel Labath via Phabricator via lldb-commits
labath planned changes to this revision. labath added a comment. Actually, it looks like the "follow-up" patch will be more complicated than I had hoped for, and so I am starting to wonder whether we shouldn't just have the unwinder check for section permissions himself (which would be a one-li

[Lldb-commits] [PATCH] D69035: minidump: Refactor memory region computation code

2019-10-16 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: clayborg, amccarth. Herald added subscribers: mgrang, mgorny. The goal of this refactor is to enable ProcessMinidump to take into account the loaded modules and their sections when computing the permissions of various ranges of memory, as discu