[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

2019-10-16 Thread Haibo Huang via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1d4a40751ff3: [lldb] move more things from python to cmake (authored by hhb). Changed prior to commit: https://reviews.llvm.org/D69016?vs=225151&id=225270#toc Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

2019-10-16 Thread Haibo Huang via Phabricator via lldb-commits
hhb added a comment. In D69016#1710466 , @mgorny wrote: > I'm not sure if I like the usage of `POST_BUILD` stuff (it provides less > control than separate targets) but overall this seems a good change. > Replacing ~250 lines of reinventing the wheel with

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

2019-10-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a reviewer: JDevlieghere. labath accepted this revision. labath added a subscriber: JDevlieghere. labath added a comment. This revision is now accepted and ready to land. In D69016#1710380 , @davide wrote: > What are you trying to accomplish h

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

2019-10-16 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. I'm not sure if I like the usage of `POST_BUILD` stuff (it provides less control than separate targets) but overall this seems a good change. Replacing ~250 lines of reinventing the wheel with ~20 lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

2019-10-15 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. What are you trying to accomplish here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69016/new/ https://reviews.llvm.org/D69016 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

2019-10-15 Thread Haibo Huang via Phabricator via lldb-commits
hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Move the copy of six.py, lldb.py and macosx/heap Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69016 Files: lldb/CMakeLists.txt lldb/scri