[Lldb-commits] [PATCH] D68968: [android/process info] Introduce display_name

2019-10-28 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 226744. wallace added a comment. now reading from comm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 Files: lldb/docs/lldb-gdb-remote.txt lldb/include/lldb/Utilit

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce display_name

2019-10-28 Thread walter erquinigo via Phabricator via lldb-commits
wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/source/Host/linux/Host.cpp:205-222 +static bool GetProcessNameFromStat(::pid_t pid, std::string& name) { + auto BufferOrError = getProcFile(pid, "stat"); + if (!BufferOrError) +return

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce display_name

2019-10-28 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. This looks pretty good. I just have one quick question about the /comm file. Comment at: lldb/source/Host/linux/Host.cpp:205-222 +static bool GetProcessNameFromStat(::pid_t pid, std::string& name) { + auto BufferOrError = getProcFile(pid, "stat"); + if

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce display_name

2019-10-21 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 225947. wallace retitled this revision from "[android/process info] Introduce bundle id" to "[android/process info] Introduce display_name". wallace edited the summary of this revision. wallace added a comment. Herald added a subscriber: kristof.beyls. now us