[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG79d8996d73f3: python path should be platform-dependent (authored by llunak). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

llunak added a comment. In D68910#1710147 , @hhb wrote: > This is fine for me. Actually it doesn't make any difference for all > platforms I tried... Out of curiosity, is it possible to share the > implementation of get_python_lib() in openSUSE? Thanks.

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

hhb added a comment. One additional statement in openSUSE comparing to standard python: libdir = plat_specific and get_config_var("platlibdir") or "lib" Hmmm basically what does platform dependent mean... Anyway this change looks good to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

hhb added a comment. Python 3.6.8 (default, Apr 30 2019, 13:27:23) [GCC] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import distutils.sysconfig >>> print(distutils.sysconfig.get_python_lib(True, False, '')) lib64/python3.6/site-packages >>> print

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

hhb accepted this revision. hhb added a comment. In D68910#1710009 , @llunak wrote: > How about this one? This is fine for me. Actually it doesn't make any difference for all platforms I tried... Out of curiosity, is it possible to share the implementat

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

llunak updated this revision to Diff 225101. llunak retitled this revision from " use LLVM_LIBDIR_SUFFIX for python lib path" to "python path should be platform-dependent". llunak edited the summary of this revision. llunak added a comment. How about this one? Repository: rLLDB LLDB CHANGES

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

llunak added a comment. In D68910#1709832 , @hhb wrote: > Can you sync to the latest code and try again? Your problem is likely to be > fixed in a previous change... With current master 'ninja install' at least proceeds without an error. But it still p