[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG208e9c01fc09: [lldb] Creates _liblldb symlink from cmake (authored by hhb). Changed prior to commit: https://reviews.llvm.org/D68858?vs=224955&id=225123#toc Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb marked an inline comment as done. hhb added a comment. In D68858#1709458 , @tatyana-krasnukha wrote: > Build and installation completed successfully! LGTM, though it would be good > if anyone tests this with Xcode. I just tested Xcode. For xcode LL

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. Build and installation completed successfully! LGTM, though it would be good if anyone tests this with Xcode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb marked 3 inline comments as done. hhb added inline comments. Comment at: lldb/CMakeLists.txt:244 + else() +set(LIBLLDB_SYMLINK_DEST "${liblldb_build_dir}/liblldb${CMAKE_SHARED_LIBRARY_SUFFIX}") + endif() tatyana-krasnukha wrote: > This command still pr

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224955. hhb added a comment. Oops fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Inde

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224954. hhb added a comment. Fix the build for multi-config generator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/fi

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

tatyana-krasnukha added a comment. F10259577: D68858d.diff @hhb, please, take a look. Slightly changed your patch to make it work for Visual Studio. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ htt

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

tatyana-krasnukha added inline comments. Comment at: lldb/CMakeLists.txt:228 +function(create_relative_symlink target dest_file output_dir output_name) + get_filename_component(dest_file ${dest_file} ABSOLUTE) + get_filename_component(output_dir ${output_dir} ABSOLU

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224707. hhb added a comment. Adds VERBATIM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Index

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224648. hhb added a comment. Fix file copy path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224649. hhb added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Index: lld

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224647. hhb added a comment. Fix file copy path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224546. hhb added a comment. Remove tailing whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLL

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb created this revision. hhb added a project: LLDB. hhb updated this revision to Diff 224544. hhb added a comment. hhb updated this revision to Diff 224545. Fix format hhb added a comment. Rebase This is another attempt of D67993 . This change removed hard

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224545. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Index: lldb/

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224544. hhb added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Index: l