[Lldb-commits] [PATCH] D68638: [lldb] Avoid resource leak

2019-10-08 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6d7fb29914e3: [lldb] Avoid resource leak (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68638/new/ https://reviews.llvm.org/D68638 Files:

[Lldb-commits] [PATCH] D68638: [lldb] Avoid resource leak

2019-10-08 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. Also, this whole function seems to have no tests. So if you find an easy way to test this, then please add a test to `functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.

[Lldb-commits] [PATCH] D68638: [lldb] Avoid resource leak

2019-10-08 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
kwk created this revision. kwk added a reviewer: jankratochvil. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before the pointer variable `args_dict` was assigned the result of an allocation with `new` and then `args_dict` is passed to `GetValueForKeyAsDictionary` which im