[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-09 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG988ad4194848: [LLDB] Remove standalone build dep on llvm-strip (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D68614?vs=224148&id=224160#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-09 Thread Gwen Mittertreiner via Phabricator via lldb-commits
gmittert updated this revision to Diff 224147. gmittert added a comment. Updated/Rebased for the rename of lit->test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: test/CMakeLists.txt Index: test/CMakeLists.

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-09 Thread Gwen Mittertreiner via Phabricator via lldb-commits
gmittert updated this revision to Diff 224148. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: test/CMakeLists.txt Index: test/CMakeLists.txt ===

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-08 Thread Gwen Mittertreiner via Phabricator via lldb-commits
gmittert added a comment. Thanks! Can someone commit this for me? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-08 Thread Alex Langford via Phabricator via lldb-commits
xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 ___ lldb-commi

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-08 Thread Gwen Mittertreiner via Phabricator via lldb-commits
gmittert updated this revision to Diff 223903. gmittert added a comment. Alright, rebased and added a comment to it Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: lit/CMakeLists.txt Index: lit/CMakeLists.txt

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-08 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd added inline comments. Comment at: lit/CMakeLists.txt:64 ) +if(NOT LLDB_BUILT_STANDALONE) + list(APPEND LLDB_TEST_DEPS llvm-strip) JDevlieghere wrote: > xiaobai wrote: > > why not `if(TARGET llvm-strip)`? I think that expresses the intent more > > c

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-08 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
kwk added a comment. I think I'm guilty for adding `llvm-strip` to `LLDB_TEST_DEPS` I wasn't aware that it might cause problems. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 ___

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lit/CMakeLists.txt:64 ) +if(NOT LLDB_BUILT_STANDALONE) + list(APPEND LLDB_TEST_DEPS llvm-strip) xiaobai wrote: > why not `if(TARGET llvm-strip)`? I think that expresses the intent more > cleanly (and conforms t

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-07 Thread Alex Langford via Phabricator via lldb-commits
xiaobai added a reviewer: JDevlieghere. xiaobai added a comment. @JDevlieghere has been touching similar things today. You should coordinate with him on this change. Comment at: lit/CMakeLists.txt:64 ) +if(NOT LLDB_BUILT_STANDALONE) + list(APPEND LLDB_TEST_DEPS llvm-strip)

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-07 Thread Gwen Mittertreiner via Phabricator via lldb-commits
gmittert created this revision. gmittert added reviewers: compnerd, kwk. Herald added subscribers: lldb-commits, JDevlieghere, mgorny. Herald added a project: LLDB. When building standalone, since llvm-strip is a symlink, it is created using add_custom_command/add_custom_target which cannot be exp