This revision was automatically updated to reflect the committed changes.
Closed by commit rGea6377505435: Replace regex match with rfind (NFCish)
(authored by aprantl).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D68609?vs=223695&id=223887#toc
Repository:
labath added inline comments.
Comment at: lldb/source/Symbol/ObjectFile.cpp:85
// Check for archive file with format "/path/to/archive.a(object.o)"
-char path_with_object[PATH_MAX * 2];
-module_sp->GetFileSpec().GetPath(path_with_object,
-
aprantl created this revision.
aprantl added reviewers: JDevlieghere, friss.
This change is mostly performance-neutral since our regex engine is fast, but
it's IMHO slightly more readable.
Also, matching matching parenthesis is not a great match for regular
expressions.
https://reviews.llvm.or
