lawrence_danna updated this revision to Diff 223900.
lawrence_danna marked 2 inline comments as done.
lawrence_danna added a comment.
style fixes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68547/new/
https://reviews.llvm.org/D68547
Files:
lld
This revision was automatically updated to reflect the committed changes.
Closed by commit rG085328ba: exception handling in PythonDataObjects.
(authored by lawrence_danna).
Changed prior to commit:
https://reviews.llvm.org/D68547?vs=223900&id=223901#toc
Repository:
rG LLVM Github Monore
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I am quite happy about how this is turning out to be. Thanks for taking your
time to do this.
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
lawrence_danna updated this revision to Diff 223691.
lawrence_danna added a comment.
review fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68547/new/
https://reviews.llvm.org/D68547
Files:
lldb/source/Plugins/ScriptInterpreter/Python/PythonDa
lawrence_danna added inline comments.
Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:280
+ template
+ Expected CallMethod(const char *name, const char *format,
+Args... args) {
labath wrote:
> I
lawrence_danna updated this revision to Diff 223690.
lawrence_danna marked 13 inline comments as done.
lawrence_danna added a comment.
review fixes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68547/new/
https://reviews.llvm.org/D68547
Files:
l
labath added a comment.
I like the direction this is going in. Some questions about the
implementation/interface inline..
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:44-45
+using llvm::Error;
+using llvm::Expected;
+
Please
lawrence_danna created this revision.
lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath, zturner.
Herald added a project: LLDB.
Python APIs nearly all can return an exception. They do this
by returning NULL, or -1, or some such value and setting
the exception state with PyErr_Se
