[Lldb-commits] [PATCH] D68361: [dsymutil] Tablegenify option parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rL373622: [dsymutil] Tablegenify option parsing (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D68361?vs=222934&id=223042#toc Repository: rL LLVM CHANGES

[Lldb-commits] [PATCH] D68361: [dsymutil] Tablegenify option parsing

JDevlieghere added a comment. In D68361#1692988 , @thegameg wrote: > I noticed a bunch of explicit `llvm::` prefixes like `llvm::Error`, > `llvm::StringRef`, etc. Did you intentionally leave that there? No, that's definitely unintentional. I'll fix the

[Lldb-commits] [PATCH] D68361: [dsymutil] Tablegenify option parsing

friss accepted this revision. friss added a comment. This seems a little heavyweight, but it reads nicely and gets rid of global state. Go for it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68361/new/ https://reviews.llvm.org/D68361 _

[Lldb-commits] [PATCH] D68361: [dsymutil] Tablegenify option parsing

thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. I noticed a bunch of explicit `llvm::` prefixes like `llvm::Error`, `llvm::StringRef`, etc. Did you intentionally leave that there? Otherwise, this LGTM, thanks for the nice cleanup! ==

[Lldb-commits] [PATCH] D68361: [dsymutil] Tablegenify option parsing

JDevlieghere created this revision. JDevlieghere added reviewers: friss, aprantl, thegameg. Herald added subscribers: llvm-commits, mgorny. Herald added projects: LLDB, LLVM. This patch reimplements command line option parsing in dsymutil with Tablegen and libOption. The main motivation for this