[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f46982b452b: [lldb-test] Modify lldb-test to print out ASTs from symbol file (authored by shafik). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D67994?vs=224479&id=22

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:9195 + GetAsEnumDecl(type->GetFullCompilerType())) + enum_decl->dump(s.AsRawOstream()); +else { teemperor wrote: > shafik wrote: > > aprantl wrote: > > > is an En

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik updated this revision to Diff 224479. shafik marked 2 inline comments as done. shafik added a comment. - Simplified DumpFromSymbolFile() based on comments - Reused -name option in lldb-test and to replace -symbol-name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67994/new/ https

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. My hope was that something like -find=variable -dump-clang-ast would make sense at least from a theoretical perspective. However, after reading to source code, it looks like that may not be tr

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik added a comment. In D67994#1697981 , @labath wrote: > In D67994#1695172 , @shafik wrote: > > > In D67994#1692645 , @labath wrote: > > > > > Maybe this is my fault sinc

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

labath added a comment. In D67994#1695172 , @shafik wrote: > In D67994#1692645 , @labath wrote: > > > Maybe this is my fault since I'm the one who introduced the first bunch of > > arguments here IIRC, but anyway,

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

teemperor added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:9195 + GetAsEnumDecl(type->GetFullCompilerType())) + enum_decl->dump(s.AsRawOstream()); +else { shafik wrote: > aprantl wrote: > > is an EnumDecl not a TagDecl

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik added a comment. In D67994#1692645 , @labath wrote: > Maybe this is my fault since I'm the one who introduced the first bunch of > arguments here IIRC, but anyway, I have a feeling all of these dumping > options are getting out of hand. Looking at

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

labath added a comment. In D67994#1691641 , @shafik wrote: > In D67994#1683934 , @labath wrote: > > > IOW, I was not saying you should use "image dump ast" to write the test you > > wanted to write. I was merely sa

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

labath added a comment. Maybe this is my fault since I'm the one who introduced the first bunch of arguments here IIRC, but anyway, I have a feeling all of these dumping options are getting out of hand. Looking at the argument list, you'd expect that -dump-ast, and -dump-clang-ast do something

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik updated this revision to Diff 222935. shafik marked 14 inline comments as done. shafik added a comment. Updates based on comments: - Remove use of AsCString() - Fixed use of old API - other minor issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67994/new/ https://reviews.llv

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

aprantl added inline comments. Comment at: include/lldb/Symbol/ClangASTContext.h:895 + /// Dump clang AST types from the symbol table + /// nit: `.` at the end Comment at: include/lldb/Symbol/ClangASTContext.h:896 + /// Dump clang AST type

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik marked 7 inline comments as done. shafik added a comment. I ended up splitting out the functionality into a new method `dumpClangAST` it looks PDB is not as lazy as DWARF and there are several PDB tests already using the current `dumpAST` as it is. Comment at: tools/ll

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik added a comment. In D67994#1683934 , @labath wrote: > In D67994#1683440 , @shafik wrote: > > > I believe this is due to us being lazy as to when we import. > > > Yes, but doesn't calling `Module::ParseAllDebu

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik updated this revision to Diff 222861. shafik retitled this revision from "[WIP] Modify lldb-test to print out ASTs from symbol file" to "Modify lldb-test to print out ASTs from symbol file". shafik added a comment. - Updated approach based on comment - Pushed clang ast manipulation into `C