[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

2019-09-23 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL372608: [LLDB] Fix logically dead code (authored by kwk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D67915?v

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

2019-09-23 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. In D67915#1679030 , @kwk wrote: > @jankratochvil the file only has two revisions: > https://github.com/llvm/llvm-project/commits/b9c1b51e

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

2019-09-23 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
kwk added a comment. @jankratochvil the file only has two revisions: https://github.com/llvm/llvm-project/commits/b9c1b51e45b845debb76d8658edabca70ca56079/lldb/include/lldb/Core/LoadedModuleInfoList.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

2019-09-23 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk added a reviewer: jankratochvil. kwk edited the summary of this revision. jankratochvil added a comment. Personally I would check GIT history for some reasons it was written this way. The indica

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

2019-09-23 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. FYI the link does not work for me: https://scan3.coverity.com/reports.htm#v39507/p12195/fileInstanceId=27614986&defectInstanceId=8037484&mergedDefectId=221581 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67915/new/

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

2019-09-23 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. Personally I would check GIT history for some reasons it was written this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67915/new/ https://reviews.llvm.org/D67915 __