[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

2019-09-24 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. In D67892#1680317 , @labath wrote: > In either case, it's sad that there are no tests breaking due to this. > Ideally we'd have a small arm64 macho core file with well known register > values that we could just assert are re

[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

2019-09-24 Thread Martin Storsjö via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL372738: [LLDB] Fix typo in RegisterContextDarwin_arm64 (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

2019-09-24 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is definitely right. I remember running into this in the past, but I don't remember whether I ended up not committing the fix, or is this another instance of that bug. In either case, it

[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

2019-09-22 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo created this revision. mstorsjo added reviewers: jasonmolenda, jingham. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. In these cases, the register number should be calculated from `fpu_d0`, not `fpu_s0`. Repository: rLLDB LLDB https://reviews.l