[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

2019-09-23 Thread Pavel Labath via Phabricator via lldb-commits
labath requested changes to this revision. labath added a comment. Like I said in the other patch, I think we're stuck with having to match how the python layouts differ between operating systems (though there is definitely a lot of room for improvement in the way that it is done now). Reposit

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

2019-09-22 Thread Michał Górny via Phabricator via lldb-commits
mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. I do not believe this to be the right approach. Unconditionally installing Python modules to the wrong directory is a bug, not a feature. It should be fixed (as I proposed in D67890

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

2019-09-22 Thread Haibo Huang via Phabricator via lldb-commits
hhb updated this revision to Diff 221251. hhb added a comment. Fix symbol linker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67866/new/ https://reviews.llvm.org/D67866 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt lldb/scripts/Pyt

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

2019-09-20 Thread Haibo Huang via Phabricator via lldb-commits
hhb updated this revision to Diff 221123. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67866/new/ https://reviews.llvm.org/D67866 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt lldb/scripts/Python/finishS

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

2019-09-20 Thread Haibo Huang via Phabricator via lldb-commits
hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Before this change, the procedure of installing and loading python modules are as follow: 1. finishSwigPythonLLDB.py writes necessary files to ${CMAKE_BINARY_DIR