[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL372194: Cache PYTHON_EXECUTABLE for windows (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D67

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220594. hhb added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake/modules/LLDBConfig

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

JDevlieghere accepted this revision. JDevlieghere added a comment. Hmm, that's unfortunately but I guess it makes sense. Let's remove the `mark_as_advanced` as it doesn't really serve a purpose anymore. Apologies about the churn! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220589. hhb added a comment. Add CACHE PATH again. I think this is the only way to go. With PARENT_SCOPE: Tthe local detected value is always used, even if a different value is set in cache. With no parameter: Always the value in cache is used. If a value is not

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220584. hhb added a comment. Turns out I still need to change previous lines to remove PARENT_SCOPE. Otherwise local value will still be used even if a different value is set in the cache. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 __

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220424. hhb added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake/modules/LLDBConfi

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

JDevlieghere added a comment. In D67641#1671917 , @hhb wrote: > In D67641#1671881 , @JDevlieghere > wrote: > > > Can we match what `FindPythonInterp ` and `FindPythonLibs` does? > > > > mark_as_advanced( > >

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb added a comment. In D67641#1671881 , @JDevlieghere wrote: > Can we match what `FindPythonInterp ` and `FindPythonLibs` does? > > mark_as_advanced( > PYTHON_EXECUTABLE > PYTHON_DEBUG_LIBRARY > PYTHON_LIBRARY > PYTHON_INCLUDE_DIR > )

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220410. hhb added a comment. Add mark_as_advanced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake/modules/

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

JDevlieghere added a comment. Can we match what `FindPythonInterp ` and `FindPythonLibs` does? mark_as_advanced( PYTHON_EXECUTABLE PYTHON_DEBUG_LIBRARY PYTHON_LIBRARY PYTHON_INCLUDE_DIR ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb added a reviewer: JDevlieghere. This way it can be overwritten when cross compiling. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LL