[Lldb-commits] [PATCH] D67474: [Reproducer] Add `reproducer dump` command

2019-09-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL371909: [Reproducer] Add reproducer dump command. (authored by JDevlieghere, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D67474?vs=219949&id=22

[Lldb-commits] [PATCH] D67474: [Reproducer] Add `reproducer dump` command

2019-09-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Approved with that addition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67474/new/ https://reviews.llvm.org/D67474 ___ lldb-commits

[Lldb-commits] [PATCH] D67474: [Reproducer] Add `reproducer dump` command

2019-09-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. The help for -f should say what happens if this option isn't provided. Otherwise this looks fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67474/new/ https://reviews.llvm.org/D67474 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D67474: [Reproducer] Add `reproducer dump` command

2019-09-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 219949. JDevlieghere added a comment. Inspect the current reproducer when in replay mode and no path is specified. Thanks for the suggestions, Jim! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67474/new/ https://reviews.llvm.org/D67474 Files

[Lldb-commits] [PATCH] D67474: [Reproducer] Add `reproducer dump` command

2019-09-11 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. If I've run lldb like: $ lldb -capture-path and then I want to dump the reproducer I've loaded, it seems annoying to have to say: (lldb) reproducer dump -f Why do I need to type it again? So it seems like you could make -f optional, and if it isn't provided use th

[Lldb-commits] [PATCH] D67474: [Reproducer] Add `reproducer dump` command

2019-09-11 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: friss, jingham, labath, LLDB. JDevlieghere added a project: LLDB. Herald added subscribers: llvm-commits, teemperor, hiraditya. Herald added a project: LLVM. This adds a `reproducer dump` commands which makes it possible to inspect