[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

labath added a comment. cool Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

This revision was automatically updated to reflect the committed changes. Closed by commit rL371796: [Target] Move InferiorCall to Process (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Excellent! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 ___

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

xiaobai updated this revision to Diff 220023. xiaobai added a comment. Rename function in question to CallVoidArgVoidPtrReturn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 Files: lldb/include/lldb/Targ

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

jingham added a comment. I don't think CallNoArgNoReturnFunc is the right name. This routine calls a function that takes no arguments but returns a void *. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

xiaobai updated this revision to Diff 220018. xiaobai added a comment. Rename InferiorCall to CallNoArgNoReturnFunc make CallNoArgReturnFunc public Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 Files: l

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

jingham added a comment. In D67472#1668505 , @clayborg wrote: > lgtm. Jim? I already commented above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 __

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

clayborg accepted this revision. clayborg added a comment. lgtm. Jim? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I was going to say LGTM unless Jim has concerns, but looks like he cut me to the chase :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

jingham added a comment. This seems like the right place to put it, it's clearly something you would do with a process. I don't see any reason why this should be a private function. It's just a convenience wrapper around a bunch of other public functionality, and doesn't do anything that need

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, compnerd, labath. Herald added a project: LLDB. InferiorCall is only ever used in Process, and it is not specific to POSIX. By moving it to Process, we can remove all dependencies on plugins from Process. Moving Inferi