labath marked an inline comment as done.
labath added inline comments.
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:549
+ llvm::Optional record = StackWinRecord::parse(*It);
+ assert(record.hasValue());
+
amccarth wrote:
> labath wrote:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL371017: Breakpad: Basic support for STACK WIN unwinding
(authored by labath, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
LGTM. Please consider adding a comment to the assert that summarizes what you
explained in the thread.
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad
labath added a comment.
We always need more tests. I've now added more tests for various boundary
conditions.
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:549
+ llvm::Optional record = StackWinRecord::parse(*It);
+ assert(record.hasValue());
+
--
labath updated this revision to Diff 218611.
labath marked 3 inline comments as done.
labath added a comment.
add more tests
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67067/new/
https://reviews.llvm.org/D67067
Files:
lit/SymbolFile/Breakpad/Inputs/unwind-via-stack-win.syms
lit/
amccarth added a comment.
This is looking pretty good.
I'm wondering whether it needs some "negative" tests.
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:549
+ llvm::Optional record = StackWinRecord::parse(*It);
+ assert(record.hasValue());
+
---
labath created this revision.
labath added reviewers: amccarth, rnk, markmentovai.
This patch makes it possible to unwind via breakpad STACK WIN records.
It is "basic" because two important features are missing:
- support for the .raSearch keyword
- support for multiple STACK WIN records within a
