[Lldb-commits] [PATCH] D67022: Skip getting declarations for repeated DIEs (WIP)

clayborg added a comment. In D67022#1653248 , @guiandrade wrote: > Hey guys, > > This change is more for me to get to know what you think. I've noticed that > the GetDeclForUIDFromDWARF() calls inside > SymbolFileDWARF::ParseDeclsForContext > (https://g

[Lldb-commits] [PATCH] D67022: Skip getting declarations for repeated DIEs (WIP)

labath added a comment. I am not very familiar with this code, but I don't see a reason why what you're doing could not work. However, it looks like the implementation of it could be done in a better way. For instance, this function seems to be the only caller of `GetDIEForDeclContext`. So, we

[Lldb-commits] [PATCH] D67022: Skip getting declarations for repeated DIEs (WIP)

guiandrade added a comment. Hey guys, This change is more for me to get to know what you guys think. I've noticed that GetDeclForUIDFromDWARF() calls inside SymbolFileDWARF::ParseDeclsForContext (https://github.com/llvm/llvm-project/blob/ef82098a800178a1f973abb8af86eaa690a29734/lldb/source/Plu

[Lldb-commits] [PATCH] D67022: Skip getting declarations for repeated DIEs (WIP)

guiandrade created this revision. guiandrade added reviewers: clayborg, labath. guiandrade added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, aprantl. guiandrade added a comment. Hey guys, This change is more for me to get to know what you guys think. I've noticed that