[Lldb-commits] [PATCH] D67018: [lldb][NFC] Add basic test for GUI command

teemperor added a comment. Yeah, the directory was pre-restructure. Moved to the right path before committing (and removed the other stuff you pointed out). Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67018/new/ https://reviews.llvm.org/D67018 __

[Lldb-commits] [PATCH] D67018: [lldb][NFC] Add basic test for GUI command

This revision was automatically updated to reflect the committed changes. Closed by commit rL370625: [lldb][NFC] Add basic test for GUI command (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D67018: [lldb][NFC] Add basic test for GUI command

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D67018#1653138 , @teemperor wrote: > Given how much fun Pavel had fixing my previous pexpect tests, I thought: > "Why stop the fun after just two te

[Lldb-commits] [PATCH] D67018: [lldb][NFC] Add basic test for GUI command

clayborg added a comment. Seems like revision 370054 sets the screen size quite wide. Just checking that this change will be used for this test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67018/new/ https://reviews.llvm.org/D67018 ___ l

[Lldb-commits] [PATCH] D67018: [lldb][NFC] Add basic test for GUI command

teemperor updated this revision to Diff 218161. teemperor added a comment. - Set terminal dimension. Yeah, Pavel added support for that (but I forgot to set them here because the test I used as a template didn't had the dimensions set). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D670

[Lldb-commits] [PATCH] D67018: [lldb][NFC] Add basic test for GUI command

clayborg added a comment. It is great to have tests. The main issue I would see is some of the text might not render correctly if the screen size is too small. Can we control the size (char width and height) of the screen in pexpect tests? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67018: [lldb][NFC] Add basic test for GUI command

teemperor created this revision. teemperor added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. teemperor added a comment. Given how much fun Pavel had fixing my previous pexpect tests, I thought: "Why stop the fun after just two t

[Lldb-commits] [PATCH] D67018: [lldb][NFC] Add basic test for GUI command

teemperor added a comment. Given how much fun Pavel had fixing my previous pexpect tests, I thought: "Why stop the fun after just two tests?". So here we go! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67018/new/ https://reviews.llvm.org/D67018 __