labath added a comment.
My other concerns about this patch are:
- the base_addr field is the *difference* between the preferred load address
encoded in the object file, and the actual load address. This means that this
workaround will fire every time the object is loaded at it's preferred load
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
It looks like this code would be better placed inside
`UpdateBaseAddrIfNecessary`, as that's exactly what it is doing.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://
xiaobai accepted this revision.
xiaobai added a comment.
Herald added a subscriber: JDevlieghere.
LGTM, small typo tho
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:553
+ // reported. Attempt to discover it based on the load address of the object
+ /
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks. I'm going to clean the diff downstream.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66858/new/
https://reviews.llvm.org/D66858
___
compnerd created this revision.
compnerd added reviewers: davide, xiaobai.
Herald added subscribers: abidh, srhines.
Herald added a project: LLDB.
In certain cases, the loader does not report the base address of the DSO.
Attempt to infer it from the loaded address of the object file. This was
ori
