[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rL370078: [lldb] Fix x86 compilation (authored by tkrasnukha, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6665

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy added a comment. @tatyana-krasnukha Can you commit this please because I have no commit access Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://reviews.llvm.org/D66655 ___ lldb-com

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://reviews.llvm.org/D66655 __

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy updated this revision to Diff 217359. leonid.mashinskiy added a reviewer: tatyana-krasnukha. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://reviews.llvm.org/D66655 Files: source/Plugins/Process/Windows/Common/NativeRegisterC

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

tatyana-krasnukha added a comment. A few typos remained after copy-pasting Comment at: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp:279 // This is likely an internal register for lldb use only and should not be // directly queried.

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy updated this revision to Diff 217140. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://reviews.llvm.org/D66655 Files: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp source/Plugins/Process/Window

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

tatyana-krasnukha added a comment. Macros `__x86_64__` and `_M_X64` are more common than AMD-branded, though there is no functional difference (unless using old versions of the Intel compiler). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://r

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy updated this revision to Diff 217101. leonid.mashinskiy added a comment. Updated used guarding macros to cut-off ARM and ARM64 architectures as @tatyana-krasnukha mentioned Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://revi

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

tatyana-krasnukha added inline comments. Comment at: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.h:9 -#if defined(_WIN64) +#if defined(_WIN32) && !defined(_WIN64) #ifndef liblldb_NativeRegisterContextWindows_i386_h_ These macros ar

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy created this revision. leonid.mashinskiy added a reviewer: asmith. leonid.mashinskiy added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D66655 Files: source/Plugins/Process/Windows/Common/NativeRegisterContextWind