xiaobai marked an inline comment as done.
xiaobai added inline comments.
Comment at:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:110
do {
- DeclVendor *modules_decl_vendor =
- m_target->GetClangModulesDeclVendor();
+ auto *modules_
shafik added inline comments.
Herald added a subscriber: usaxena95.
Comment at:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:110
do {
- DeclVendor *modules_decl_vendor =
- m_target->GetClangModulesDeclVendor();
+ auto *modules_decl_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL369424: [ClangExpressionParser] Add ClangDeclVendor
(authored by xiaobai, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66451/new/
https://reviews.llvm.org/D66451
_
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Symbol/DeclVendor.h:27
+eAppleObjCDeclVendor,
+eLastClangDeclVendor,
+ };
xiaobai wrote:
> JDevlieghere wrote:
> > What's `eLastClangDeclVendor` and where is it used?
> Following the advic
xiaobai marked an inline comment as done.
xiaobai added inline comments.
Comment at: lldb/include/lldb/Symbol/DeclVendor.h:27
+eAppleObjCDeclVendor,
+eLastClangDeclVendor,
+ };
JDevlieghere wrote:
> What's `eLastClangDeclVendor` and where is it used?
Fol
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Symbol/DeclVendor.h:27
+eAppleObjCDeclVendor,
+eLastClangDeclVendor,
+ };
What's `eLastClangDeclVendor` and where is it used?
Comment at: lldb/source/Plugins/ExpressionP
xiaobai created this revision.
xiaobai added reviewers: JDevlieghere, clayborg, jingham, labath.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: LLDB.
This introduces a layer between DeclVendor and the currently implemented
DeclVendors (ClangM
