[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil added a comment. In D66398#1679071 , @labath wrote: > Good to know, but assuming that the above patch sticks, the plan *is* to > revert this, right? D66654 is already checked-in, I have considered it as d

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

labath added a comment. In D66398#1677414 , @jankratochvil wrote: > "jankratochvil added a reverting change" - that is not true, Differential got > somehow confused by the commit text there talking about this patch. Good to know, but assuming that the

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil added a comment. "jankratochvil added a reverting change" - that is not true, Differential got somehow confused by the commit text there talking about this patch. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66398/new/ https://reviews.llvm.org/D663

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil added a comment. In D66398#1640871 , @labath wrote: > because these kinds of regular are horrid. Yes, they are. So let's link with PCRE (BSD licensed). > What was the problem with the dispatching solution? I do not

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

This revision was automatically updated to reflect the committed changes. Closed by commit rL369655: [lldb] Fix `TestDataFormatterStdList` regression (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D66398#1640840 , @jankratochvil wrote: > It just makes now the regexes unambiguous. I think this is fine too, but I would also only consider it a

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil added a comment. In D66398#1635344 , @labath wrote: > Since it seems that there is a need for disambiguation (libc++ can be > configured to have any name for the inline namespace, so there's no way to > make its regex not match the libstdc+

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil updated this revision to Diff 216585. jankratochvil edited the summary of this revision. jankratochvil added a comment. It just makes now the regexes unambiguous. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66398/new/ https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

JDevlieghere accepted this revision. JDevlieghere added inline comments. Comment at: lldb/source/DataFormatters/FormatManager.cpp:950 + RegularExpression any_size_char_arr(llvm::StringRef("char \\[[0-9]+\\]")); +#if 0 // FIXME: unused: + RegularExpression any_size_wchar_arr(llv

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I very much support getting rid of shared pointers, and for this is I am inclined to accept this. However, I don't think it was ever really intended to use the sorting order of the regex text

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil added a comment. From IRC: In fact the whole patch is a oneliner (+`operator<` for `RegularExpression.h`): - typedef FormattersContainer RegexMatchContainer; + typedef FormattersContainer RegexMatchContainer; The rest of the patch is just a mechanical update to make it comp

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil updated this revision to Diff 215895. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66398/new/ https://reviews.llvm.org/D66398 Files: lldb/include/lldb/Breakpoint/BreakpointResolverName.h lldb/include/lldb/DataFormatters/FormattersContainer.h

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil created this revision. jankratochvil added reviewers: JDevlieghere, labath, jingham, clayborg. jankratochvil added a project: LLDB. Herald added a reviewer: jdoerfert. jankratochvil added a parent revision: D66392: 1/2: D66174 `RegularExpression` follow-up/cleanup. Since D66174