This revision was automatically updated to reflect the committed changes.
Closed by commit rL368879: [DebugLine] Improve path handling. (authored by
JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D66227?vs=215142&id=215151#toc
Repository:
rL LLVM
CHANGES SIN
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
LGTM with some minor details addressed, thanks!
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:1044
+/// Guess the path style from the given absolute path.
+stat
aprantl added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:183
+ llvm::Optional style = FileSpec::GuessPathStyle(p);
+ return style ? *style : FileSpec::Style::native;
+}
you can just use llvm::Optional::getValueOr(FileS
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, wolfgangp, stella.stamenova.
Herald added subscribers: llvm-commits, hiraditya, aprantl.
Herald added projects: LLDB, LLVM.
JDevlieghere added a comment.
This should fix the following two test failures on the Windows LLDB bo
JDevlieghere added a comment.
This should fix the following two test failures on the Windows LLDB bot
(http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja)
LLDB :: SymbolFile/DWARF/debug-line-basic.s
LLDB :: SymbolFile/DWARF/dir-separator-posix.s
Unfortunately I don't have access to a
