[Lldb-commits] [PATCH] D65955: Minidump/Windows: Fix module lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rL368416: Minidump/Windows: Fix module lookup (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D65955: Minidump/Windows: Fix module lookup

labath added a comment. In D65955#1621400 , @amccarth wrote: > I'm curious, though, where is the matching code? Should "unknown" be treated > as a wildcard when trying to find the matching module? The matching code lives ArchSpec::IsEqualTo, and its be

[Lldb-commits] [PATCH] D65955: Minidump/Windows: Fix module lookup

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. This looks fine, and thanks for the tests for a one-line fix. I'm curious, though, where is the matching code? Should "unknown" be treated as a wildcard when trying to find the matching m

[Lldb-commits] [PATCH] D65955: Minidump/Windows: Fix module lookup

labath created this revision. labath added reviewers: clayborg, amccarth. Herald added subscribers: kristof.beyls, javed.absar. When opening a minidump, we were failing to find an executable because we were searching for i386-unknown-windows, whereas we recognize the pe/coff files as i386-pc-windo