[Lldb-commits] [PATCH] D65910: Remove unused and undocumented data_offset parameter

2019-08-08 Thread Phabricator via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368330: Remove unused and undocumented data_offset parameter (NFC) (authored by adrian, committed by ). Herald added a pro

[Lldb-commits] [PATCH] D65910: Remove unused and undocumented data_offset parameter

2019-08-07 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. From the looks of it, this appears to be the offset in the data extractor that you want to start extracting from (so, e.g. if you have a large data extractor, and you know that the value you're interested in is at byte 47, you would say `GetValueAsData(large_extractor, 4

[Lldb-commits] [PATCH] D65910: Remove unused and undocumented data_offset parameter

2019-08-07 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl created this revision. aprantl added reviewers: jingham, clayborg, labath, jasonmolenda. Herald added a project: LLDB. aprantl updated this revision to Diff 214024. Value::GetValueAsData() takes an undocumented parameter called data_offset that is always 0. I couldn't figure out what it i

[Lldb-commits] [PATCH] D65910: Remove unused and undocumented data_offset parameter

2019-08-07 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl updated this revision to Diff 214024. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65910/new/ https://reviews.llvm.org/D65910 Files: lldb/include/lldb/Core/Value.h lldb/source/Core/Value.cpp lldb/source/Core/ValueObject.cpp lldb/source/Core/ValueObjectCast.cpp lldb/sou